Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build_test_package.py osc syntax #3473

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rktidwell
Copy link
Contributor

As of osc version 0.164.2 the --all option must be supplied on
deleterequest operations. This changes allow build_test_package.py
to work on systems with newer versions of open build service commander.

nicolasbock
nicolasbock previously approved these changes Jun 6, 2019
Copy link
Contributor

@nicolasbock nicolasbock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Note, this change was added in openSUSE/osc@677c741

@nicolasbock
Copy link
Contributor

CI errors are PEP8 linter issues. Should be easy to fix though.

Copy link
Member

@bmwiedemann bmwiedemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems, there is an import for "version" missing.

scripts/jenkins/ardana/gerrit/build_test_package.py Outdated Show resolved Hide resolved
scripts/jenkins/ardana/gerrit/build_test_package.py Outdated Show resolved Hide resolved
scripts/jenkins/ardana/gerrit/build_test_package.py Outdated Show resolved Hide resolved
Copy link
Contributor Author

@rktidwell rktidwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mistakenly pushed from the wrong branch. Let me push the correct changes.

As of osc version 0.164.2 the --all option must be supplied on
deleterequest operations. This changes allow build_test_package.py
to work on systems with newer versions of open build service commander.
@rktidwell rktidwell force-pushed the fix-osc-deleterequest-all-option branch from e8ba5d2 to d58ae4e Compare June 6, 2019 15:32
Copy link
Contributor

@nicolasbock nicolasbock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing! Looks great!

@nicolasbock
Copy link
Contributor

Still a PEP8 error in CI. This time a different error 😉

@rktidwell
Copy link
Contributor Author

Still a PEP8 error in CI. This time a different error

Yeah, I'm still fighting with this. I'm getting conflicting directives about what should go where locally. Stay tuned.....

@stefannica
Copy link
Contributor

needs a rebase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants