Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dedicated QA scenarios for Cloud 8 to Cloud 9 upgrade (SOC-10460) #3682

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jgrassler
Copy link
Contributor

This pull request adds dedicated QA scenarios for the Cloud 8 to Cloud 9 upgrade. It consists of a commit with an unmodified copy of the original Cloud 8 scenarios and a commit on top of that to add the modifications we need for upgrade testing (in order to allow for diffing).

This commit creates dedicated Cloud 8 scenarios for the Cloud
8 to Cloud 9 upgrade. As of this commit they are a unmodified
copy of the regular Cloud 8 scenarios (for diffability, they
will be modified to account for deprecations in a later commit).
This commit makes various adjustments to the Cloud 8
upgrade QA scenarios to account for things that would
otherwise fail prechecks:

* Removes Aodh and Trove deployment from all Cloud 8
  upgrade scenarios.
* Ceilometer is removed from all scenarios
  that lack Monasca.
* The nova-compute-kvm role is no longer assigned in any
  scenarios (use the regular Cloud 8 scenarios to check
  whether the precheck for that role being present triggers)
@jgrassler jgrassler force-pushed the qa-scenarios-c8-c9-upgrade branch from 0ae4bb9 to 467ec5f Compare September 9, 2019 14:07
This commit adds an optional scenario_dir option to the QA
scenario jobs. This option allows a user to specify a custom
scenario directory, which is needed to reach the special
upgrade scenarios in the cloud8-upgrade directory.
Copy link
Contributor

@JanZerebecki JanZerebecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except one inline comment.
A few nits, that don't need to be fixed: Commit 1 has some changes that the message says are in commit 2. Commit 2 removes some nova-compute-xen, but message talks only about kvm.

# based on $cloud_version and $ssl_type.

if [ -z "$scenario_dir" ]; then
scenario_dir=scripts/scenarios/cloud$cloud_version/qa/$ssl_type/$scenario_file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove $scenario_file as otherwise it is duplicated below. Same with all files changed in this commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants