Bm25 #61
Merged
Bm25 #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes aim to introduce the possibility to use BM25 as a filter instead of Suffix-array.
The code is restructured with two abstract classes Filte and, FilterMatches with each having respectively the previously defined SuffixArray and NGramMatches. Now there is BM25 inheriting from Filter, and BM25Matches from FilterMatches.
Their is a new external library, Eigen, that is not mandatory in general, but necessary to use BM25.
New entry parameters are available to switch between Suffix-array and BM25, as well as using BM25 specific parameters.
This new BM25 filter is considerably slower than Suffix-array, but further optimizations in the future could make it competitive.
/!/!/!
For some reason, the projects builds successfully locally (regardless whether Eigen available), but fails during the online workflow.