Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(crates): update crate versions and fix breaking changes #3

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Yukigeshiki
Copy link

@Yukigeshiki Yukigeshiki commented Jan 11, 2024

I found this repo extremely useful and wanted to use it with the latest crate versions.

Crates updated:

  • axum 0.4 -> 0.7.3
  • hyper 0.14 -> 1.1.0
  • config 0.12 -> 0.13.4
  • tracing-log 0.1 -> 0.2.0
  • sqlx 0.5 -> 0.7.3
  • uuid 0.8 -> 1.6.1
  • tower-http 0.2 -> 0.5.0

@SaadiSave
Copy link
Owner

Hi, I just saw this PR. It looks good, I'll test it and merge if everything works. I'm glad that this repo helped you.

@SaadiSave
Copy link
Owner

SaadiSave commented Apr 4, 2024

Hey, sorry for the delay, I had exams in February and March. I have a few questions regarding the changes.

  1. Since hyper removed the server from its 1.0 release, do you believe it is prudent to use the axum provided server? The axum team made it quite clear that the server is not designed for production use (iirc), and since this is supposed to be as close to production as possible, I think it would be better to wait for the promised server in hyper-extras (? not sure if that's what it's called).
  2. I'm not sure if I missed some developments regarding time/chrono. Has chrono been fixed? Or has time fallen into disuse?
  3. Should I create a new branch on the repo and restart from scratch with new library versions? It is, after all, an educational repo, and it seems less than desirable to update everything in an older codebase if people are supposed to follow it chapter-by-chapter from the book. Do you agree?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants