Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

load_mnist_data with split #137

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

sohamyedgaonkar
Copy link

hope This solves what you were trying to
suggest any changes if so

@SaashaJoshi
Copy link
Owner

Hi @sohamyedgaonkar,
I was thinking more along the lines of adding a test-train-split argument to the existing load_mnist_dataset function so that users do not have to call a second function. What do you think?

@SaashaJoshi SaashaJoshi added the hacktoberfest-accepted Approved for Hacktoberfest label Oct 15, 2024
@SaashaJoshi
Copy link
Owner

Hi @sohamyedgaonkar, any updates?

@sohamyedgaonkar
Copy link
Author

sohamyedgaonkar commented Oct 31, 2024

Hey @SaashaJoshi Can you just brief me about which function are you talking about
(I mean from which library and it's version)
I had pulled a request with using a tf.keras.load_mnist .I thought It would have solved the issue

Please guide me what is expected in detail so that I can really contribute

@SaashaJoshi
Copy link
Owner

This is the load_mnist_dataset function, here. I wish to have the train_test_split as an argument to this method such that the user only has to mention a ratio of the spilt when calling the function.

I think @ketayon solved something similar in PR #138.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Approved for Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants