Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IT-2360] Setup IAM roles for tower #286

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

zaro0508
Copy link
Contributor

@zaro0508 zaro0508 commented Feb 5, 2024

This is a 2nd attempt at PR #229 which was reverted in commit 698a3ff. The first attempt failed because AWS wanted to re-create the ECS service without first deleting the existing resource therefore cloudformation responded with this error..

TowerService AWS::ECS::Service UPDATE_FAILED Resource handler returned message:
"Resource of type 'AWS::ECS::Service' with identifier 'Nextflow-Tower-Service'
already exists."

This PR will require some manual intervention to help guide it thru.

This is a 2nd attempt at PR Sage-Bionetworks-Workflows#229 which was reverted in commit
698a3ff. The first attempt failed because AWS wanted to
re-create the ECS service without first deleting the existing
resource therefore cloudformation responded with this error..

```
TowerService AWS::ECS::Service UPDATE_FAILED Resource handler returned message:
"Resource of type 'AWS::ECS::Service' with identifier 'Nextflow-Tower-Service'
already exists."
```

This PR will require some manual intervention to help guide
it thru.
@zaro0508 zaro0508 requested a review from a team as a code owner February 5, 2024 22:25
Copy link

sonarcloud bot commented Feb 5, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@zaro0508 zaro0508 requested a review from BWMac February 5, 2024 22:27
@thomasyu888
Copy link
Collaborator

Will review and merge this after we test the dev environment for the patch that just went out. The patch is blocking work that has been stalled for some time.

Copy link
Collaborator

@thomasyu888 thomasyu888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 LGTM!

@thomasyu888 thomasyu888 merged commit 1a2158b into Sage-Bionetworks-Workflows:dev Feb 8, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants