Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IT-3929] Upgrade MySql version #355

Closed
wants to merge 1 commit into from

Conversation

zaro0508
Copy link
Contributor

@zaro0508 zaro0508 commented Oct 14, 2024

MySql 5.7 is EOL therefore we need to upgrade to the new AWS supported version of MySql

This is going to do an In-place upgrade[1]. The idea is to upgrade it in dev environment -> test -> propogate to prod -> test.

[1] https://docs.aws.amazon.com/AmazonRDS/latest/AuroraUserGuide/Aurora.MySQL57.EOL.html#Aurora-Performing-an-Upgrade

MySql 5.7 has been deprecated we need to upgrade a the new
AWS supported version.

This is going to do an `In-place upgrade`[1].  The idea is
to upgrade it in dev environment -> test -> propogate
to staging -> test -> propogate to prod.

[1] https://docs.aws.amazon.com/AmazonRDS/latest/AuroraUserGuide/Aurora.MySQL57.EOL.html#Aurora-Performing-an-Upgrade
@zaro0508 zaro0508 requested a review from a team as a code owner October 14, 2024 21:04
Copy link

sonarcloud bot commented Oct 14, 2024

Copy link
Contributor

@BryanFauble BryanFauble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update! Are there any breaking changes that your aware of?

@zaro0508 zaro0508 requested review from a team and BWMac October 14, 2024 21:06
@thomasyu888
Copy link
Collaborator

thomasyu888 commented Oct 14, 2024

We don't have a staging, but it'd be nice if this: https://sagebionetworks.jira.com/browse/IT-3888 was in place to automate the testing of this. We can still probably merge and wait for Brad to be back from Vacation to fully test dev deployment

@zaro0508
Copy link
Contributor Author

Thanks for the update! Are there any breaking changes that your aware of?

I don't know much about the software that's using the DB so i kinda have no idea. I'm guessing @BWMac would probably know and be testing that it works after the upgrade.

Copy link
Contributor

@BWMac BWMac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

In their docs, Seqera states that the new version is supported and they do not give any warnings that I am aware of in terms of breaking changes so 🤞🏻 it plays out that way in our deployment.

@zaro0508
Copy link
Contributor Author

Manually tested this but in-place replacement didn't work.
AWS returned following error..

UPDATE_FAILED Resource handler returned message: 
"Cannot find upgrade target from 5.7.serverless_mysql_aurora.2.11.4 
with requested version 8.0.mysql_aurora.3.07.1 for serverless 
engine mode

We will need to do a full migration.

@zaro0508 zaro0508 closed this Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants