Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added register-admin route, reading json data from body #82

Closed

Conversation

dhananjaysingh10
Copy link
Contributor

Issue #76

  • Added register-admin route
  • solved the problem, admin data saving multiple time in DB
  • Saving password in encrypted form in DB
  • earlier routes can not parse JSON data from due to one error in app.js file (faced this problem while testing, Now solved)
    I have improved my code, please let me no if there are some error. I will try my best to fix them.
    I have attached some of the screenshots
    Screenshot (50)
    Screenshot (51)
    Screenshot (52)
    Screenshot (55)

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @dhananjaysingh10! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.

We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

@dhananjaysingh10
Copy link
Contributor Author

dhananjaysingh10 commented May 14, 2024

Please let me know If there are any Bug or error in the code @Sahil1786 .
If there is any error pls let me know where to improve

@Sahil1786
Copy link
Owner

Sahil1786 commented May 17, 2024

at first you need write the command git pull in terminal to up to date with repository then you need work admin data which is saving multiple time into database also remove the hard coded values into the env files

@dhananjaysingh10
Copy link
Contributor Author

Ok thanks for your help i will try to complete this task soon

@dhananjaysingh10
Copy link
Contributor Author

@Sahil1786 I have updated my branch, now it does not have any merge conflict.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants