-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added register-admin route, reading json data from body #94
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, @dhananjaysingh10! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.
We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines
Sorry I closed the last PR by mistake, This PR has no merge conflict, also ADMIN Data is NOT Saved multiple times in DB. Also there is no hard coded value now. to access the admin page first we have to Register then only we can login to admin dashboard |
Show me some images |
Sir there is no username, in user schema, All the schemas should be defined more precisely for ease of other developer so we do not need to revise the same portion of code again and again as our schema changes |
4b2ad23
to
8bd2b29
Compare
Hello @Sahil1786 please let me know if there is any problem in the code |
branch has conflicts that must be resolved |
@Sahil1786 please check it does not have any conflict right now |
@Sahil1786 Please check my work and suggest changes if needed. All the schemas should be defined more precisely for the ease of other developers so we do not need to revise the same portion of code again and again as our schema changes |
Issue #76
solved the problem, admin data saving multiple time in DB
Added register-admin route
Saving password in encrypted form in DB
I have improved my code, please let me no if there are some error. I will try my best to fix them.