Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blackened and ruffed #244

Merged
merged 2 commits into from
Sep 14, 2023
Merged

Blackened and ruffed #244

merged 2 commits into from
Sep 14, 2023

Conversation

jkbhagatio
Copy link
Member

@jkbhagatio jkbhagatio commented Sep 2, 2023

@coderabbitai: ignore

Summary by CodeRabbit

  • Refactor: Improved code readability and maintainability across multiple modules by reordering imports, renaming variables, and updating function signatures.
  • Bug Fix: Enhanced error handling in the frames function in aeon/io/video.py to include more detailed information in error messages.
  • Documentation: Updated and clarified docstrings for several functions across different modules.
  • Style: Standardized string literals and import statements across the codebase for consistency.
  • New Feature: Modified the chunk and load functions in aeon/io/api.py to handle both single values and series of timestamps.
  • Test: Updated test cases in tests/io/test_api.py to reflect changes in the main codebase.

@github-actions

This comment was marked as resolved.

github-actions[bot]

This comment was marked as resolved.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image description CodeRabbit

Commits Files that changed from the base of the PR and between eb306bd and 0c63c9a commits.
Files selected (35)
  • .pre-commit-config.yaml (2)
  • aeon/analysis/movies.py (7)
  • aeon/analysis/plotting.py (6)
  • aeon/analysis/utils.py (4)
  • aeon/dj_pipeline/init.py (2)
  • aeon/dj_pipeline/acquisition.py (27)
  • aeon/dj_pipeline/analysis/in_arena.py (22)
  • aeon/dj_pipeline/analysis/visit.py (5)
  • aeon/dj_pipeline/device_stream.py (3)
  • aeon/dj_pipeline/docs/notebooks/diagram.ipynb (3)
  • aeon/dj_pipeline/ingest/create_experiment_01.py (6)
  • aeon/dj_pipeline/ingest/create_experiment_02.py (2)
  • aeon/dj_pipeline/ingest/create_socialexperiment_0.py (5)
  • aeon/dj_pipeline/ingest/load_metadata.py (10)
  • aeon/dj_pipeline/ingest/process.py (5)
  • aeon/dj_pipeline/lab.py (6)
  • aeon/dj_pipeline/qc.py (4)
  • aeon/dj_pipeline/report.py (13)
  • aeon/dj_pipeline/scripts/clone_and_freeze_exp01.py (2)
  • aeon/dj_pipeline/subject.py (2)
  • aeon/dj_pipeline/tracking.py (9)
  • aeon/dj_pipeline/utils/paths.py (3)
  • aeon/dj_pipeline/utils/plotting.py (4)
  • aeon/io/api.py (5)
  • aeon/io/device.py (2)
  • aeon/io/reader.py (5)
  • aeon/io/video.py (2)
  • aeon/qc/video.py (1)
  • aeon/schema/core.py (1)
  • aeon/schema/dataset.py (1)
  • aeon/schema/foraging.py (2)
  • aeon/schema/octagon.py (1)
  • aeon/schema/social.py (4)
  • aeon/util.py (1)
  • tests/io/test_api.py (1)
Files ignored due to filter (1)
  • pyproject.toml
Files not summarized due to errors (4)
  • aeon/dj_pipeline/acquisition.py (diff tokens exceeds limit)
  • aeon/dj_pipeline/analysis/in_arena.py (diff tokens exceeds limit)
  • aeon/io/reader.py (diff tokens exceeds limit)
  • aeon/schema/octagon.py (diff tokens exceeds limit)
Files skipped from review due to trivial changes (25)
  • aeon/analysis/movies.py
  • aeon/analysis/utils.py
  • aeon/dj_pipeline/init.py
  • aeon/dj_pipeline/analysis/visit.py
  • aeon/dj_pipeline/device_stream.py
  • aeon/dj_pipeline/docs/notebooks/diagram.ipynb
  • aeon/dj_pipeline/ingest/create_experiment_02.py
  • aeon/dj_pipeline/ingest/create_socialexperiment_0.py
  • aeon/dj_pipeline/ingest/process.py
  • aeon/dj_pipeline/lab.py
  • aeon/dj_pipeline/qc.py
  • aeon/dj_pipeline/scripts/clone_and_freeze_exp01.py
  • aeon/dj_pipeline/subject.py
  • aeon/dj_pipeline/tracking.py
  • aeon/dj_pipeline/utils/paths.py
  • aeon/dj_pipeline/utils/plotting.py
  • aeon/io/api.py
  • aeon/io/device.py
  • aeon/qc/video.py
  • aeon/schema/core.py
  • aeon/schema/dataset.py
  • aeon/schema/foraging.py
  • aeon/schema/social.py
  • aeon/util.py
  • tests/io/test_api.py
Review comments generated (53)
  • Review: 29
  • LGTM: 24

Tips

Chat with Image description CodeRabbit Bot (@coderabbitai)

  • Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
  • Invite the bot into a review comment chain by tagging @coderabbitai in a reply.

Code suggestions

  • The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
  • You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.

Pausing incremental reviews

  • Add @coderabbitai: ignore anywhere in the PR description to pause further reviews from the bot.

aeon/analysis/plotting.py Show resolved Hide resolved
.pre-commit-config.yaml Show resolved Hide resolved
.pre-commit-config.yaml Outdated Show resolved Hide resolved
aeon/dj_pipeline/ingest/create_experiment_01.py Outdated Show resolved Hide resolved
aeon/dj_pipeline/ingest/create_experiment_01.py Outdated Show resolved Hide resolved
aeon/dj_pipeline/report.py Outdated Show resolved Hide resolved
aeon/dj_pipeline/report.py Outdated Show resolved Hide resolved
aeon/dj_pipeline/report.py Outdated Show resolved Hide resolved
aeon/dj_pipeline/report.py Outdated Show resolved Hide resolved
aeon/dj_pipeline/report.py Outdated Show resolved Hide resolved
@jkbhagatio
Copy link
Member Author

Note: revert changes to all files within 'aeon/dj_pipeline' - these will be appropriately reformatted in a separate PR

@jkbhagatio jkbhagatio merged commit bdb3dcd into main Sep 14, 2023
4 of 7 checks passed
@jkbhagatio jkbhagatio deleted the big_autoformat branch October 3, 2023 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant