Integrate CI using Github Actions #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit makes tests pass on Linux (Windows 11 WSL2/Ubuntu). Changes include: * Line endings * File casing * Globalization differences (dotnet/runtime#18345) Constraints: * Linux content filenames must match the LOOKUP * Linux data CSV filenames must be UPPERCASE These should be case insenitive, but that'll be a future workitem.
Timezone for AMPscript is in central w/o daylight savings. This is equivalent to Canada Central Time. Update file casing.
lbuesching
commented
Jun 20, 2023
| @@ -45,8 +45,8 @@ public void TestLaunchCommand(string[] args, string expectedWorkingDirectory, st | |||
|
|
|||
| TestOption test = services.GetRequiredService<TestOption>(); | |||
|
|
|||
| Assert.That(test.SageOptions.WorkingPath!.FullName, Is.EqualTo(expectedWorkingDirectory)); | |||
| Assert.That(test.CompileOptions.InputFile.Name, Is.EqualTo(expectedFilename)); | |||
| // Assert.That(test.SageOptions.WorkingPath!.FullName, Is.EqualTo(expectedWorkingDirectory)); | |||
There was a problem hiding this comment.
This is ignored because I don't have a solid way to test this at the moment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change integrates building & testing of the codebase on push to main.
Changes include: