-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: initial commit for adding types #146
Conversation
WalkthroughThe recent updates introduce the Changes
Poem
Tip Early access features: enabledWe are currently testing the following features in early access:
Note:
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- packages/common/src/controllers/dto/file-upload.dto.ts (1 hunks)
Additional context used
Biome
packages/common/src/controllers/dto/file-upload.dto.ts
[error] 1-1: expected
=
but instead found{
Remove {
(parse)
@@ -0,0 +1,5 @@ | |||
export type FileUploadDTO { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix the syntax error in the type definition.
The export type
syntax should use =
instead of {
for type alias definition.
- export type FileUploadDTO {
+ export type FileUploadDTO = {
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
export type FileUploadDTO { | |
export type FileUploadDTO = { |
Tools
Biome
[error] 1-1: expected
=
but instead found{
Remove {
(parse)
Checklist
Make sure you have
@nestjs/swagger
decorators wherever requiredDescription
Describe the aim/objective of this PR
Steps to test
Add steps to run and test teh desired changes
References
Add relevant links and screenshots outlining the working status of this PR
Demo
If relevant to your change, attach a screen recording showcasing that the change is working and giving desired results.
Summary by CodeRabbit