-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Url encoding #165
Url encoding #165
Conversation
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
@@ -78,48 +89,42 @@ | |||
} else { | |||
this.logger.log(`Directory already exists at ${uploadsDir}`); | |||
} | |||
fs.writeFileSync(localFilePath, file.buffer); | |||
return destination; | |||
fs.writeFileSync(localFilePath, saveToLocalRequestDto.file.buffer); |
Check failure
Code scanning / CodeQL
Uncontrolled data used in path expression High
user-provided value
'uploads', | ||
fileDownloadRequestDto.destination, | ||
); // don't use __dirname here that'll point to the dist folder and not the top level folder containing the project (and the uploads folder) | ||
const fileStream = fs.createReadStream(localFilePath); |
Check failure
Code scanning / CodeQL
Uncontrolled data used in path expression High
user-provided value
this PR is no longer needed since I have added the changes for this in #159 |
Description
Added url-encoding for file-upload feature