Skip to content

Commit

Permalink
Draft: use onecc on ubuntu 24.04
Browse files Browse the repository at this point in the history
- Install command for ubuntu 24.04: same with ubuntu 18.04 to use python 3.8 explicitly

ONE-DCO-1.0-Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
  • Loading branch information
hseok-oh committed Jan 2, 2025
1 parent c93d12c commit c728272
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 4 deletions.
2 changes: 2 additions & 0 deletions compiler/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ endif()

if(${ONE_UBUNTU_CODENAME} STREQUAL "bionic")
set(ONE_UBUNTU_CODENAME_BIONIC TRUE)
elseif(${ONE_UBUNTU_CODENAME} STREQUAL "noble")
set(ONE_UBUNTU_CODENAME_NOBLE TRUE)
endif()

# TODO Validate the argument of "requires"
Expand Down
8 changes: 4 additions & 4 deletions compiler/one-cmds/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -42,13 +42,13 @@ if(CMAKE_HOST_SYSTEM_PROCESSOR STREQUAL "aarch64")
# and install build/../one-prepare-venv file
list(APPEND ONE_COMMAND_FILES one-prepare-venv.aarch64)
else(CMAKE_HOST_SYSTEM_PROCESSOR STREQUAL "aarch64")
if(ONE_UBUNTU_CODENAME_BIONIC)
if(ONE_UBUNTU_CODENAME_BIONIC OR ONE_UBUNTU_CODENAME_NOBLE)
# NOTE copy one-prepare-venv.u1804 as build/../one-prepare-venv
# and install build/../one-prepare-venv file
list(APPEND ONE_COMMAND_FILES one-prepare-venv.u1804)
else(ONE_UBUNTU_CODENAME_BIONIC)
else(ONE_UBUNTU_CODENAME_BIONIC OR ONE_UBUNTU_CODENAME_NOBLE)
list(APPEND ONE_COMMAND_FILES one-prepare-venv)
endif(ONE_UBUNTU_CODENAME_BIONIC)
endif(ONE_UBUNTU_CODENAME_BIONIC OR ONE_UBUNTU_CODENAME_NOBLE)
endif(CMAKE_HOST_SYSTEM_PROCESSOR STREQUAL "aarch64")

# pytorch importer is an experimental feature, it is not used in default configuration
Expand Down Expand Up @@ -78,7 +78,7 @@ foreach(ONE_COMMAND IN ITEMS ${ONE_COMMAND_FILES})
GROUP_READ GROUP_EXECUTE
WORLD_READ WORLD_EXECUTE
DESTINATION bin)

endforeach(ONE_COMMAND)

set(ONE_UTILITY_FILES
Expand Down

0 comments on commit c728272

Please sign in to comment.