Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[onert] Add override to setMinMaxRecordsThreshold #14499

Merged
merged 1 commit into from
Dec 27, 2024

Conversation

hseok-oh
Copy link
Contributor

@hseok-oh hseok-oh commented Dec 26, 2024

This commit add override keyword to Quantizer::setMinMaxRecordsThreshold.
It will fix build fail on clang.

ONE-DCO-1.0-Signed-off-by: Hyeongseok Oh hseok82.oh@samsung.com

This commit add override keyword to Quantizer::setMinMaxRecordsThreshold.
It will fix build fail on clang.

ONE-DCO-1.0-Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
@hseok-oh hseok-oh added the PR/ready for review It is ready to review. Please review it. label Dec 26, 2024
@hseok-oh hseok-oh requested a review from a team December 26, 2024 06:19
Copy link
Contributor

@seockho-kim seockho-kim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hseok-oh
Copy link
Contributor Author

@chunseoklee Please add @seockho-kim to @Samsung/one_onert

@hseok-oh hseok-oh removed the request for review from a team December 27, 2024 01:02
@hseok-oh hseok-oh merged commit 9629003 into Samsung:master Dec 27, 2024
9 checks passed
@hseok-oh hseok-oh deleted the override_odc_q branch December 27, 2024 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR/ready for review It is ready to review. Please review it.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants