Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[luci/service] Remove useless null check #14517

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

hseok-oh
Copy link
Contributor

@hseok-oh hseok-oh commented Jan 3, 2025

This commit removes null check created by loco::NodePool::create().
When node creation fails, it throws an exception instead of returning nullptr.

ONE-DCO-1.0-Signed-off-by: Hyeongseok Oh hseok82.oh@samsung.com


Related: #14503 (comment)

This commit removes null check created by loco::NodePool::create().
When node creation fails, it throws an exception instead of returning nullptr.

ONE-DCO-1.0-Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
@hseok-oh hseok-oh added the PR/ready for review It is ready to review. Please review it. label Jan 3, 2025
Copy link
Contributor

@jinevening jinevening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@seanshpark seanshpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seanshpark seanshpark merged commit 0dc8806 into Samsung:master Jan 3, 2025
9 checks passed
@hseok-oh hseok-oh deleted the luci_service_nullcheck_create branch January 3, 2025 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR/ready for review It is ready to review. Please review it.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants