set name if alias is nullptr for use #1056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it's worth considering if there should be a default parameter value for alias, which is set to nullptr. In case you agree to remove it, I'll update the PR and set ecs_check(entity != 0 || name != NULL, ECS_INVALID_PARAMETER, NULL); to ecs_check(entity != 0 && name != NULL, ECS_INVALID_PARAMETER, NULL); in ecs_entity_t flecs_set_identifier. In case we do, then the if(!name) check in use is quite redundant and we could optionally remove it since flecs_set_identifier already deals will nullptr name where it just removes the previous alias and sets no new (as far as I understand)
|
optionally if it's nullptr, we could just early out and do nothing? edit: made discussions with Sander in private |
|
Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it's worth considering if there should be a default parameter value for alias, which is set to nullptr.
In case you agree to remove it, I'll update the PR and
set ecs_check(entity != 0 || name != NULL, ECS_INVALID_PARAMETER, NULL);to
ecs_check(entity != 0 && name != NULL, ECS_INVALID_PARAMETER, NULL);in
flecs_set_identifierfunctionIn case we do, then the
if(!name)check inusefunction is quite redundant and we could optionally remove it since flecs_set_identifier already deals will nullptr name where it just removes the previous alias and sets no new (as far as I understand)