Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark overriden methods explicitly to avoid warnings in more strict bu… #1218

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Mark overriden methods explicitly to avoid warnings in more strict bu… #1218

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion include/flecs/addons/cpp/mixins/filter/builder_i.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,7 @@ struct filter_builder_i : term_builder_i<Base> {
}

protected:
virtual flecs::world_t* world_v() = 0;
virtual flecs::world_t* world_v() override = 0;
int32_t m_term_index;
int32_t m_expr_count;

Expand Down
2 changes: 1 addition & 1 deletion include/flecs/addons/cpp/mixins/observer/builder_i.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ struct observer_builder_i : filter_builder_i<Base, Components ...> {
}

protected:
virtual flecs::world_t* world_v() = 0;
virtual flecs::world_t* world_v() override = 0;

private:
operator Base&() {
Expand Down
2 changes: 1 addition & 1 deletion include/flecs/addons/cpp/mixins/query/builder_i.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ struct query_builder_i : filter_builder_i<Base, Components ...> {
Base& observable(const query_base& parent);

protected:
virtual flecs::world_t* world_v() = 0;
virtual flecs::world_t* world_v() override = 0;

private:
operator Base&() {
Expand Down
2 changes: 1 addition & 1 deletion include/flecs/addons/cpp/mixins/system/builder_i.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ struct system_builder_i : query_builder_i<Base, Components ...> {
}

protected:
virtual flecs::world_t* world_v() = 0;
virtual flecs::world_t* world_v() override = 0;

private:
operator Base&() {
Expand Down
2 changes: 1 addition & 1 deletion include/flecs/addons/cpp/mixins/term/builder_i.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -412,7 +412,7 @@ struct term_builder_i : term_id_builder_i<Base> {
ecs_term_t *m_term;

protected:
virtual flecs::world_t* world_v() = 0;
virtual flecs::world_t* world_v() override = 0;

void set_term(ecs_term_t *term) {
m_term = term;
Expand Down
6 changes: 3 additions & 3 deletions include/flecs/addons/cpp/utils/iterable.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,7 @@ struct iter_iterable final : iterable<Components...> {
}

protected:
ecs_iter_t get_iter(flecs::world_t *world) const {
ecs_iter_t get_iter(flecs::world_t *world) const override {
if (world) {
ecs_iter_t result = m_it;
result.world = world;
Expand All @@ -243,11 +243,11 @@ struct iter_iterable final : iterable<Components...> {
return m_it;
}

ecs_iter_next_action_t next_action() const {
ecs_iter_next_action_t next_action() const override {
return m_next;
}

ecs_iter_next_action_t next_each_action() const {
ecs_iter_next_action_t next_each_action() const override {
return m_next_each;
}

Expand Down
Loading