Automatic aspect ratio calculation #733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Grid with new aspect ratio argument
|
It doesn't seem to work on macOS, but it looks like it's not an issue of the pull request since this same thing is happening on the other pull requests. |
|
Another thing I would recommend adding are tests for the aspect ratio |
SarthakJariwala
added
enhancement
|
I saw all the comments and they all seem reasonable. I addressed all the issues you raised, Everything should be correct now. |
SarthakJariwala
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I commented on issue #732, I had an idea to calculate the aspect ratio of the figure when using ImageGrid so that there isn't so much white space between subplots when displaying images with uneven aspect ratios.
I implemented it by setting the parameter
aspectto'auto', which triggers a couple of lines of code to calculate it from the dimensions of the image. Since lists of images are also supported, I also made it so it uses the lowest aspect ratio among the images, since it would make them overlap in the figure otherwise.