Develop #25
Merged
Develop #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
kstopa
commented
Mar 5, 2024
kstopa
commented
- Added tests
- Added GitHub actions
- Added flake8 listing
- Updated docs
merwok
reviewed
Mar 5, 2024
| :return: sunrise datetime. | ||
| :raises: SunTimeException when there is no sunrise and sunset on given location and date. | ||
| """ | ||
| date = datetime.datetime.now() if date is None else date |
There was a problem hiding this comment.
FYI changing this is a regression: the today value is captured when the module is imported and the function is defined, then it stays the same as long as the process runs. Any web app for example using this function with the default value would get incorrect results after some time.
(+ also a doc issue: mention of now is not accurate, the value is a date not a datetime)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.