Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix demux handler #320

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Conversation

tpapaioa
Copy link
Collaborator

@tpapaioa tpapaioa commented Sep 20, 2024

Podman has changed the return value format for exec commands, when demux=True:

containers/podman-py#410

This PR updates from_duplexed_exec to handle the new return format.

PRT results: /job/robottelo-pr-testing/8753

@JacobCallahan JacobCallahan added the enhancement New feature or request label Sep 20, 2024
@JacobCallahan
Copy link
Member

Since this is new to 5.2 (don't currently know exact version), can you update the pyproject.toml to require >=5.2?

@tpapaioa
Copy link
Collaborator Author

Since this is new to 5.2 (don't currently know exact version), can you update the pyproject.toml to require >=5.2?

Updated.

@tpapaioa tpapaioa marked this pull request as ready for review September 20, 2024 14:56
broker/session.py Outdated Show resolved Hide resolved
Copy link
Member

@JacobCallahan JacobCallahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, nice!

@JacobCallahan JacobCallahan merged commit 0bf360c into SatelliteQE:master Sep 20, 2024
4 checks passed
@tpapaioa tpapaioa deleted the fix_demux_handler branch September 20, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants