Convert bookmarks upgrade scenarios to new format #16856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
synkd
added
CherryPick
|
trigger: test-robottelo |
|
trigger: test-robottelo |
1 similar comment
|
trigger: test-robottelo |
|
PRT Result |
Satellite-QE
added
the
PRT-Passed
As part of the upgrade scenarios conversion effort, this PR changes the bookmarks upgrade scenario tests to use the shared resource framework and converts the pre-upgrade scenarios to pytest fixtures. It also adds a new shared Satellite fixture for search component tests.
synkd
force-pushed
the
convert_bookmarks_scenario_to_new_format
branch
from
1771cbf
to
6ec3c3e
Compare
Satellite-QE
removed
the
PRT-Passed
vsedmik
approved these changes
Nov 7, 2024
There was a problem hiding this comment.
Looks neat and great!
The only thing - would you mind to update the CODEOWNERS file with the new additions? We use it for the team-based review requests / heads up. Thank you!
|
@vsedmik Just updated with the change to the CODEOWNERS file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the upgrade scenarios conversion effort, this PR changes the bookmarks upgrade scenario tests to use the shared resource framework and converts the pre-upgrade scenarios to pytest fixtures. It also adds a new shared Satellite fixture for search component tests.