Convert perf tuning upgrade scenario to new format #16929
+108
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
synkd
added
Upgrades
|
trigger: test-robottelo |
|
PRT Result |
Satellite-QE
added
the
PRT-Passed
Copilot
AI
left a comment
Copilot
AI
left a comment
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 suggestion.
Comments skipped due to low confidence (2)
tests/new_upgrades/conftest.py:106
- [nitpick] The variable name
sat_instanceis ambiguous. It should be renamed tosatellite_instancefor clarity.
sat_instance = shared_checkout("perf_tuning_upgrade")
tests/new_upgrades/conftest.py:108
- [nitpick] The variable name
sat_instanceis ambiguous. It should be renamed tosatellite_instancefor clarity.
"perf_tuning_upgrade_tests", shared_checkin, sat_instance=sat_instance
| @@ -0,0 +1,97 @@ | |||
| """Test for Performance Tuning related Upgrade Scenario's | |||
There was a problem hiding this comment.
The word 'Scenario's' should be 'Scenarios'.
Suggested change
| """Test for Performance Tuning related Upgrade Scenario's | |
| """Test for Performance Tuning related Upgrade Scenarios |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
JacobCallahan
requested changes
Nov 18, 2024
| def perf_tuning_upgrade_setup(perf_tuning_upgrade_shared_satellite, upgrade_action): | ||
| """In preupgrade scenario we apply non-default tuning size. | ||
|
|
||
| :id: preupgrade-83404326-20b7-11ea-a370-48f17f1fc2e1 |
There was a problem hiding this comment.
we should be able to drop ids for this since it's a fixture now
| """In postupgrade scenario, we verify the set tuning parameters and custom-hiera.yaml | ||
| file's content. | ||
|
|
||
| :id: postupgrade-31e26b08-2157-11ea-9223-001a4a1601d8 |
There was a problem hiding this comment.
May be best to remove post-upgrade from these as well
Suggested change
| :id: postupgrade-31e26b08-2157-11ea-9223-001a4a1601d8 | |
| :id: 31e26b08-2157-11ea-9223-001a4a1601d8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the current upgrade scenarios refactor, this PR converts the performance tuning scenario to use the
SharedResourceframework, converts the pre-upgrade test to a Pytest fixture, and adds a Satellite upgrade fixture for this scenario.