Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Donwload policy on_demand supported for file type repository #16960

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dosas
Copy link
Collaborator

@dosas dosas commented Nov 20, 2024

see Katello/katello#11184

Problem Statement

see title

Solution

adapt tests

Related Issues

relevant tests
tests/foreman/cli/test_repository.py::TestRepository::test_negative_create_repos_with_download_policy

tests/foreman/api/test_repository.py::TestRepository::test_negative_create_repos_with_download_policy

@dosas dosas added the No-CherryPick PR doesnt need CherryPick to previous branches label Nov 20, 2024
@dosas dosas requested a review from a team as a code owner November 20, 2024 08:57
@Satellite-QE
Copy link
Collaborator

Can one of the admins verify this patch?

Copy link
Contributor

@vsedmik vsedmik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @dosas. Could you please rebase/resolve conflict since #16961 got merged?
Please update the docstrings too. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No-CherryPick PR doesnt need CherryPick to previous branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants