Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add permission tests for foreman_salt #16962

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Add permission tests for foreman_salt #16962

merged 1 commit into from
Nov 22, 2024

Conversation

dosas
Copy link
Collaborator

@dosas dosas commented Nov 20, 2024

Problem Statement

Missing foreman_salt permissions

Solution

Add permissions

Related Issues

similar to #16892

relevant tests: tests/foreman/api/test_permission.py

@dosas dosas added CherryPick PR needs CherryPick to previous branches 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 6.16.z Introduced in or relating directly to Satellite 6.16 labels Nov 20, 2024
@dosas dosas requested review from a team as code owners November 20, 2024 11:04
@Satellite-QE
Copy link
Collaborator

Can one of the admins verify this patch?

ogajduse
ogajduse approved these changes Nov 21, 2024
View reviewed changes
Copy link
Member

@ogajduse ogajduse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I triggered a completely internal build of PRT, build no. 9420. Test failures I have seen are not related to this patch.

@lhellebr
Copy link
Contributor

ACK if the one question is answered satisfactorily.

@dosas dosas requested a review from lhellebr November 21, 2024 14:32
@pondrejk pondrejk merged commit 4e276e0 into SatelliteQE:master Nov 22, 2024
8 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 22, 2024
@dosas @web-flow
Add permission tests for foreman_salt (#16962)
5ec8840 
(cherry picked from commit 4e276e0)
This was referenced Nov 22, 2024
Merged
Open
Open
lhellebr pushed a commit that referenced this pull request Nov 28, 2024
@Satellite-QE @dosas
[6.16.z] Add permission tests for foreman_salt (#16984)
81e0c57 
Add permission tests for foreman_salt (#16962)

(cherry picked from commit 4e276e0)

Co-authored-by: dosas <dosas@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogajduse ogajduse ogajduse approved these changes

@pondrejk pondrejk pondrejk approved these changes

@lhellebr lhellebr lhellebr approved these changes

Assignees

@dosas dosas

Labels
6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 6.16.z Introduced in or relating directly to Satellite 6.16 CherryPick PR needs CherryPick to previous branches
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dosas @Satellite-QE @lhellebr @pondrejk @ogajduse