[6.15.z] Refactor ipv6 http_proxy code #16978
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherrypick of PR: #16928
Problem Statement
enable_ipv6_http_proxy
anddisable_ipv6_http_proxy
is incorrect and confusing.Satellite
andCapsule
classes ofrobottelo/hosts.py
haveenable_ipv6_http_proxy
. The one present in Satellite is for setting HTTP proxy in Satellite settings(content and general HTTP proxy). And the one in Capsule is for enabling HTTP proxy for dnf and rhsm.Solution
enable_ipv6_http_proxy
anddisable_ipv6_http_proxy
fromSatellite
andCapsule
classes.enable_satellite_http_proxy
anddisable_satellite_http_proxy
to enable/disable ipv4/ipv6 HTTP proxy.enable_satellite_ipv6_http_proxy
inSatellite
class to set Ipv6 HTTP proxy in Satellite settings, rhsm, and dnf.enable_ipv6_dnf_and_rhsm_proxy
toContenHost
class so all the three kind of hosts can use it (Satellite, Capsule, Client).test_installer_modules_check
and covers it intest_satellite_installation
.test_capsule_installation
as it'll be covered by default (Satellite will have HTTP proxy enabled)Related Issues