Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.15.z] Refactor ipv6 http_proxy code #16978

Merged

Conversation

Satellite-QE
Copy link
Collaborator

Cherrypick of PR: #16928

Problem Statement

  • The current design of enable_ipv6_http_proxy and disable_ipv6_http_proxy is incorrect and confusing.
  • Satellite and Capsule classes of robottelo/hosts.py have enable_ipv6_http_proxy. The one present in Satellite is for setting HTTP proxy in Satellite settings(content and general HTTP proxy). And the one in Capsule is for enabling HTTP proxy for dnf and rhsm.
  • This design doesn't allow Satellite to set dnf and rhsm proxies.

Solution

  • Removeenable_ipv6_http_proxy and disable_ipv6_http_proxy from Satellite and Capsule classes.
  • Add enable_satellite_http_proxy and disable_satellite_http_proxy to enable/disable ipv4/ipv6 HTTP proxy.
  • Add enable_satellite_ipv6_http_proxy in Satellite class to set Ipv6 HTTP proxy in Satellite settings, rhsm, and dnf.
  • Add enable_ipv6_dnf_and_rhsm_proxy to ContenHost class so all the three kind of hosts can use it (Satellite, Capsule, Client).
  • This PR also removes test_installer_modules_check and covers it in test_satellite_installation.
  • It also remove http_proxy test parameterization for test_capsule_installation as it'll be covered by default (Satellite will have HTTP proxy enabled)

Related Issues

  • SAT-29467
  • Depends on satellite-jenkins#1556

@Satellite-QE Satellite-QE requested review from a team as code owners November 21, 2024 13:00
@Satellite-QE Satellite-QE added 6.15.z Introduced in or relating directly to Satellite 6.15 Auto_Cherry_Picked Automatically cherrypicked PR using GHA No-CherryPick PR doesnt need CherryPick to previous branches labels Nov 21, 2024
@ogajduse ogajduse merged commit a186efa into 6.15.z Nov 21, 2024
13 checks passed
@ogajduse ogajduse deleted the cherry-pick-6.15.z-3c820d49e26aa48327ec8d9325e027b4901cb65b branch November 21, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.15.z Introduced in or relating directly to Satellite 6.15 Auto_Cherry_Picked Automatically cherrypicked PR using GHA No-CherryPick PR doesnt need CherryPick to previous branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants