Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use char-based override instead of string in EndsWith #386

Merged
merged 2 commits into from
Jul 14, 2024

Conversation

Thorium
Copy link
Contributor

@Thorium Thorium commented Jul 8, 2024

@cartermp
Copy link
Collaborator

cartermp commented Jul 8, 2024

Some tests failing!

@Thorium
Copy link
Contributor Author

Thorium commented Jul 8, 2024

Oh, of course .LastIndexOf "/" = 0 is rather .StartsWith rather than .EndsWith, however it's a weird StartsWith because it's not StartsWith if there are more than one /. I was hoping not to go the whole string through to detect "StartsWith", but as I'm not familiar of the initial developer intention, I rather just returned that line to the previous implementation.

@cartermp cartermp merged commit 4ae4d61 into SaturnFramework:main Jul 14, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants