-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: set autoConnet() expiry time #307
feat: set autoConnet() expiry time #307
Conversation
Hi, sound good. It is set to a defined time before reconnecting with useAutoConnect, the TLL is set to 60 sg in milliseconds @Iwueseiter should check the format of the changes to ensure they comply with the rules, run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please keep CI green !
Hi @Iwueseiter , remember that today is the last day of the ODHack, you just need toead comments, Only run the tests so that the CI Jobs is ok |
Noted |
…into expiry_autoconnect
@metalboyrick I’ve ran all the formatting commands, but it’s still failing. I noticed Prettier wasn’t included in the dependencies, so I had to install it. Also, what formatting style is the CI expecting? There’s no .prettierrc configuration file in the codebase. |
We use the default NextJS core vitals for linting. You can try running If that does not work I've checked for you what the formatter expects, It expected double quotes instead of single quotes for the strings. You can ping us in the telegram group ASAP should you run into further troubles, I have the same handle. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small comments and you're good!
const [_, setLastConnector] = useLocalStorage<{ id: string; ix?: number }>( | ||
"lastUsedConnector", | ||
{ id: "" }, | ||
{ | ||
initializeWithValue: false, | ||
}, | ||
); | ||
const [, setLastConnectionTime] = useLocalStorage<number>( | ||
"lastConnectionTime", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kindly extract this "lastConnectionTime"
to a constant, thank you!
@metalboyrick please review. |
Hi @Iwueseiter, Thanks a lot for your All changes updated, and Approved for me, need review by @metalboyrick |
@metalboyrick kindly review. Thank you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, all good! thanks for the hard work!
Set autoConnet() expiry time
Fixes #280
Types of change
Comments (optional)