Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Replace yarn deploy:reset with yarn deploy #308

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Jemiiah
Copy link
Contributor

@Jemiiah Jemiiah commented Oct 3, 2024

Replaced yarn deploy:reset with yarn deploy, Created a yarn deploy —no-reset

Fixes #285

Types of change

  • Feature
  • Bug
  • Enhancement

Comments (optional)

@Nadai2010
Copy link
Contributor

Hi @Jemiiah , I think the idea is not what we wanted to do.

The yarn deploy should act like the deploy:reset works, that is, the yarn deploy will deploy new contracts replacing the previous ones in the deployments/chain_lastest.json and the yarn deploy --no-reset should deploy new contracts but without replacing or resetting the previous ones (the old ones will remain as deployments/chain_1892739817.json) and the new ones deployed will be in deployments/chain_lastest.json

I'm right @jrcarlos2000 ??

Adjust the scripts so that it works like this

@0xquantum3labs
Copy link
Collaborator

Hi @Jemiiah , I think the idea is not what we wanted to do.

The yarn deploy should act like the deploy:reset works, that is, the yarn deploy will deploy new contracts replacing the previous ones in the deployments/chain_lastest.json and the yarn deploy --no-reset should deploy new contracts but without replacing or resetting the previous ones (the old ones will remain as deployments/chain_1892739817.json) and the new ones deployed will be in deployments/chain_lastest.json

I'm right @jrcarlos2000 ??

Adjust the scripts so that it works like this

correct this is the idea @Jemiiah @Nadai2010 @metalboyrick

@@ -12,7 +12,8 @@
},
"scripts": {
"chain": "yarn workspace @ss-2/snfoundry chain",
"deploy": "yarn workspace @ss-2/snfoundry deploy",
"deploy": "node script.js",
"deploy:normal": "yarn workspace @ss-2/snfoundry deploy",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets not have this deploy:normal script.

@Nadai2010
Copy link
Contributor

Hi @Jemiiah remember today is the last day of the ODHack, check the comments, understand the issue and make the changes, thank you.

@metalboyrick
Copy link
Collaborator

Hey @Jemiiah, any updates on this?

@Nadai2010
Copy link
Contributor

Hi @Jemiiah, the ODHack is about to end, please upload your latest changes as soon as possible, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CHORE] Replace yarn deploy:reset with yarn deploy, Create a yarn deploy —no-reset
4 participants