Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: configure contracts page #33

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

mexes20
Copy link

@mexes20 mexes20 commented Oct 6, 2024

Task name here

Fixes Issue 21

Types of change

  • doc

@Nadai2010
Copy link
Collaborator

Hi @mexes20, good work, but in this documentation I think a simple guide with images with the steps to follow would be very useful.

We also have to clarify that it will depend on the chain added in scaffold.config.ts, it will access to download a contract in the sepolia or mainnet network (sometimes they will be the same addresses but not always) so we must clarify the chain thing.

@metalboyrick metalboyrick linked an issue Oct 7, 2024 that may be closed by this pull request
@metalboyrick
Copy link
Collaborator

Hi @mexes20, please note that ODHack8 is ending soon! I think you should be good once you resolve @Nadai2010 comments!

@mexes20
Copy link
Author

mexes20 commented Oct 7, 2024

Hi @mexes20, please note that ODHack8 is ending soon! I think you should be good once you resolve @Nadai2010 comments!

Alright, I'm on it now.

@mexes20
Copy link
Author

mexes20 commented Oct 7, 2024

@metalboyrick @Nadai2010 Kindly review, I made a couple of Improvements to the doc for more clarity.

Copy link
Collaborator

@metalboyrick metalboyrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies I know I said that we're good but I realized theres some changes needed to be done

docs/quick-start/configure-contracts.mdx Outdated Show resolved Hide resolved
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just remember that this was updated, refer to this PR: Scaffold-Stark/scaffold-stark-2#303

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just remember that this was updated, refer to this PR: Scaffold-Stark/scaffold-stark-2#303

@metalboyrick This is still showing at the top of the page next to the Debug Contracts, kindly confirm before I update the PR

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

This is the latest main branch

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay

@mexes20
Copy link
Author

mexes20 commented Oct 7, 2024

@metalboyrick Kindly review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add documentation for "Configure Contracts" page
3 participants