Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility to switch of ghost records in the staging macro #192

Merged
merged 6 commits into from
Sep 3, 2024

Conversation

tkiehn
Copy link
Collaborator

@tkiehn tkiehn commented Jun 28, 2024

By introducing the parameter enable_ghost_records it is possible to disable the creation of ghost records in the staging macros.

The default value for the new parameter is set to true which reflects the current behavior.




Reminder to update the wiki when merging this PR.

@tkiehn tkiehn added the enhancement New feature or request label Jun 28, 2024
@tkiehn tkiehn requested a review from tkirschke June 28, 2024 09:27
@tkiehn tkiehn linked an issue Jun 28, 2024 that may be closed by this pull request
@tkirschke
Copy link
Member

Soft-approve, wait for Pipeline testing

@tkirschke tkirschke added the testing To trigger the automated test workflow as internal User. label Sep 2, 2024
empty commit to trigger pipeline
@remoteworkflow
Copy link

remoteworkflow bot commented Sep 2, 2024

Link to workflow summary: https://github.com/ScalefreeCOM/datavault4dbt-ci-cd/actions/runs/10668908634


RESULTS for Synapse:
❌ dbt-tests
❌ dbt-macro-tests


RESULTS for Postgres:
❌ dbt-tests
❌ dbt-macro-tests


RESULTS for BigQuery:
❌ dbt-tests
❌ dbt-macro-tests


RESULTS for Redshift:
❌ dbt-tests
❌ dbt-macro-tests


RESULTS for Snowflake:
❌ dbt-tests
❌ dbt-macro-tests


RESULTS for Exasol:
❌ dbt-tests
❌ dbt-macro-tests

@remoteworkflow
Copy link

remoteworkflow bot commented Sep 3, 2024

Link to workflow summary: https://github.com/ScalefreeCOM/datavault4dbt-ci-cd/actions/runs/10677943739


RESULTS for Synapse:
✅ dbt-tests
✅ dbt-macro-tests


RESULTS for Postgres:
✅ dbt-tests
✅ dbt-macro-tests


RESULTS for BigQuery:
✅ dbt-tests
✅ dbt-macro-tests


RESULTS for Redshift:
❌ dbt-tests
✅ dbt-macro-tests


RESULTS for Snowflake:
✅ dbt-tests
✅ dbt-macro-tests


RESULTS for Exasol:
❌ dbt-tests
✅ dbt-macro-tests

@remoteworkflow
Copy link

remoteworkflow bot commented Sep 3, 2024

Link to workflow summary: https://github.com/ScalefreeCOM/datavault4dbt-ci-cd/actions/runs/10678553197


RESULTS for Synapse:
✅ dbt-tests
✅ dbt-macro-tests


RESULTS for Postgres:
✅ dbt-tests
✅ dbt-macro-tests


RESULTS for BigQuery:
✅ dbt-tests
✅ dbt-macro-tests


RESULTS for Redshift:
✅ dbt-tests
✅ dbt-macro-tests


RESULTS for Snowflake:
✅ dbt-tests
✅ dbt-macro-tests


RESULTS for Exasol:
❌ dbt-tests
❌ dbt-macro-tests

@tkiehn
Copy link
Collaborator Author

tkiehn commented Sep 3, 2024

Reminder to update the wiki when merging this PR.

@tkirschke tkirschke merged commit 846171c into main Sep 3, 2024
1 check passed
@tkirschke tkirschke deleted the 99-ghost-records-may-not-be-switched-off branch September 3, 2024 12:11
@tkirschke
Copy link
Member

Reminder to update the wiki when merging this PR.

Was merged, please update the wiki @tkiehn 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request testing To trigger the automated test workflow as internal User.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ghost Records may not be switched off
2 participants