Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat:] added support for cargo-binstall #1282

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

SkySingh04
Copy link

@SkySingh04 SkySingh04 commented Oct 13, 2024

This PR updates the CI workflow to:

  1. Consistent Naming Convention: Standardizes the naming of artifacts produced during the build process across different operating systems and architectures. This new naming convention adheres to the format:

    • For Windows:
      • fnm-x86_64-pc-windows-msvc.zip
      • fnm-arm64-pc-windows-msvc.zip
    • For macOS:
      • fnm-aarch64-apple-darwin.zip
      • fnm-x86_64-apple-darwin.zip
    • For Linux:
      • fnm-x86_64-unknown-linux-musl.zip
      • fnm-arm64-unknown-linux-gnueabihf.zip
  2. Added binstall.toml file to support cargo binstall fnm

Note : Currently the binstall.toml file is set to target packages in existing release nomenclature like https://github.com/Schniz/fnm/releases/download/v1.37.2/fnm-macos.zip

Related Issue : #1280

Signed-off-by: Akash <akashsingh2210670@gmail.com>
…ries

Signed-off-by: Akash <akashsingh2210670@gmail.com>
Copy link

changeset-bot bot commented Oct 13, 2024

⚠️ No Changeset found

Latest commit: 238160e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Oct 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fnm ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 13, 2024 8:53pm

Comment on lines +13 to +36
# Linux (x86_64)
[[package.targets.linux]]
url = "https://github.com/Schniz/fnm/releases/download/v1.37.2/fnm-linux.zip"
checksum = "sha256:439ccbc11e65df970500833e152b896c107f3f3014ea7aaf42213241b403338c"

# macOS (x86_64)
[[package.targets.mac]]
url = "https://github.com/Schniz/fnm/releases/download/v1.37.2/fnm-macos.zip"
checksum = "sha256:a886932043e8c1dee457a733e57edc39df2287d9952a96948155df2a0b6b26b1"

# Windows (x86_64)
[[package.targets.windows]]
url = "https://github.com/Schniz/fnm/releases/download/v1.37.2/fnm-windows.zip"
checksum = "sha256:4f634f9153635e4af26ea96b15c01a28e5e4acc03849a0b51a86be9c70897173"

# ARM32
[[package.targets.linux-arm]]
url = "https://github.com/Schniz/fnm/releases/download/v1.37.2/fnm-arm32.zip"
checksum = "sha256:7047833cdfab2287899dcd686d26b84a2398f43b5aa1cf0f370e0826e89fe039"

# ARM64
[[package.targets.linux-arm64]]
url = "https://github.com/Schniz/fnm/releases/download/v1.37.2/fnm-arm64.zip"
checksum = "sha256:8db196f4bcbb2f27b4742bd5a898ab79d444006d121f888d9201bb3690419763"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh no, is there a way it'll be automatic
i might need to append this portion upon release?

@Schniz
Copy link
Owner

Schniz commented Nov 13, 2024

that's an exciting change
but can we make this nonbreaking for the current installation script by uploading artifacts with both the new and old name? i don't mind having duplicated files with different names just to maintain backward compatibility :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants