-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get tests working on github #20
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't reviewed everything, as in this merge request github seems to double-count a ton of code, but probably as the code is working mostly fine. I'd just request to roll back some of the loop maximum changes from num_cells+2 to num_cells+1, as the last ghost cell often creates problems, and doesn't need to be updated in some cases anyway (like the rad transport)
I can't because the collisional heating test with radiative transfer fails if I do. The problem is that with a limit of With the current implementation the hydro works properly, as demonstrated by the shock-tube tests, and the radiation works properly as demonstrated by the irradiation tests, so I don't think there is really a problem with the current implementation. |
This pull request fixes the automatic tests and sets up Github to run them automatically on pushes