Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove variante read/write button from standalone env #364

Merged
merged 1 commit into from
Nov 28, 2024
Merged

fix: remove variante read/write button from standalone env #364

merged 1 commit into from
Nov 28, 2024

Conversation

louisgreiner
Copy link
Collaborator

Description

As this box is always "read-only", we can just remove it, to make the UI clearer

From:
image

To:
image

Issues

Checklist

  • This PR contains a description of the changes I'm making
  • I've read the Contribution Guidelines
  • I've added tests for changes or features I've introduced
  • I documented any high-level concepts I'm introducing in documentation/
  • CI is currently green and this is ready for review

@louisgreiner
remove variante read/write button from standalone env
f6b5023 
Signed-off-by: Louis Greiner <greiner.louis@gmail.com>
aiAdrian
aiAdrian approved these changes Nov 27, 2024
View reviewed changes
Copy link
Collaborator

@aiAdrian aiAdrian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank u

@aiAdrian aiAdrian changed the title remove variante read/write button from standalone env fix: remove variante read/write button from standalone env Nov 27, 2024
emersion
emersion approved these changes Nov 27, 2024
View reviewed changes
Copy link
Collaborator

@emersion emersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@louisgreiner louisgreiner merged commit 1f28a51 into main Nov 28, 2024
7 checks passed
@louisgreiner louisgreiner deleted the lgr/remove-variante-button-from-standalone branch November 28, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aiAdrian aiAdrian aiAdrian approved these changes

@emersion emersion emersion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@louisgreiner @emersion @aiAdrian