Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LDAP integration #143

Merged
merged 10 commits into from
Jun 10, 2024
Merged

LDAP integration #143

merged 10 commits into from
Jun 10, 2024

Conversation

fpotier
Copy link
Member

@fpotier fpotier commented Apr 24, 2024 •
edited
Loading

  • LDAP container
  • Initialize the LDAP domain with user
  • backend config
  • backendnext config
  • frontend config
  • Global README
  • LDAP README
  • backendnext README
  • backend README

@fpotier fpotier force-pushed the ldap branch 2 times, most recently from 0379612 to 2dabe9b Compare April 24, 2024 15:40
@fpotier fpotier force-pushed the ldap branch 4 times, most recently from 1060051 to 3d307b8 Compare May 29, 2024 13:15
@fpotier fpotier marked this pull request as ready for review May 29, 2024 13:32
@fpotier fpotier requested a review from minottic May 29, 2024 13:39
minottic
minottic reviewed May 29, 2024
View reviewed changes
services/backend/services/ldap/config/ldifs/02-users.ldif Outdated Show resolved Hide resolved
services/backend/services/v4/compose.yaml Outdated Show resolved Hide resolved
services/frontend/compose.yaml Show resolved Hide resolved
services/frontend/config/init.sh Outdated Show resolved Hide resolved
services/frontend/config/init.sh Show resolved Hide resolved
.github/workflows/compose_test.yaml Outdated Show resolved Hide resolved
services/backend/services/v3/compose.base.yaml Outdated Show resolved Hide resolved
services/backend/services/v3/config/mergeJson.js Outdated Show resolved Hide resolved
services/backend/services/v3/compose.yaml Outdated Show resolved Hide resolved
services/backend/services/v3/README.md Outdated Show resolved Hide resolved
minottic
minottic reviewed Jun 10, 2024
View reviewed changes
Copy link
Contributor

@minottic minottic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the exclude logic for LDAP is missing from the be init.sh

.github/workflows/compose_test.yaml Outdated Show resolved Hide resolved
services/backend/services/v3/config/mergeJson.js Outdated Show resolved Hide resolved
@minottic
Copy link
Contributor

I realised the exclude is not required as the file is mounted only when ldap is enabled

@minottic minottic self-requested a review June 10, 2024 10:45
@fpotier fpotier merged commit 09df2f3 into main Jun 10, 2024
12 checks passed
@fpotier fpotier deleted the ldap branch June 10, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minottic minottic minottic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fpotier @minottic