Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename docker compose #152

Merged
merged 2 commits into from
May 23, 2024
Merged

Rename docker compose #152

merged 2 commits into from
May 23, 2024

Conversation

minottic
Copy link
Contributor

No description provided.

@minottic minottic requested a review from a team May 22, 2024 17:33
@minottic minottic force-pushed the rename_docker_compose branch from 791d9e9 to c47c047 Compare May 22, 2024 17:33
@minottic minottic mentioned this pull request May 23, 2024
Merged
fpotier
fpotier approved these changes May 23, 2024
View reviewed changes
Copy link
Member

@fpotier fpotier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was a bit confused as why you would want to rename but after seeing the other PR, lgtm

@minottic
Copy link
Contributor Author

thanks! lol, the reason is silly in the end and it's just that defaulting to compose is easier than to docker-compose (and also looks nicer IMO)

@minottic minottic merged commit a8f1ec8 into main May 23, 2024
6 checks passed
@minottic minottic deleted the rename_docker_compose branch May 23, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpotier fpotier fpotier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@minottic @fpotier