Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: standardise workflows using SciML's reusable workflows #50

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

thazhemadam
Copy link
Member

Update the workflows in this repository to use SciML's reusable workflows.
This is part of a larger effort to standardise the SciML's CI workflows for more generic and common requirements, to keep the workflows uniform and easier to maintain.

Copy link

codecov bot commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (43f1a41) to head (a67c600).

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #50   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines           64        64           
=========================================
  Hits            64        64           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdalle
Copy link
Collaborator

gdalle commented Apr 30, 2024

Where does this build the docs? And are they updated directly upon each merged PR?

@thazhemadam
Copy link
Member Author

The documentation is still built on the same events as it is at present, i.e., on pushes to main, on all tags pushed and on all pull requests opened. The status quo is expected to remain unchanged.

on:
push:
branches:
- main
tags: '*'
pull_request:

@gdalle
Copy link
Collaborator

gdalle commented Apr 30, 2024

I mean on which website, does it go to a centralized SciML docs or does it stay here?

@thazhemadam
Copy link
Member Author

Ah, I see. Sorry about the misunderstanding. The documentation deployments will continue to stay here, as specified in the deploydocs method.

repo = "github.com/SciML/ADTypes.jl.git"

@gdalle
Copy link
Collaborator

gdalle commented Apr 30, 2024

Sounds good to me, but I'll let someone from the org like @Vaibhavdixit02 review and merge, I only have rights to this specific repo

@Vaibhavdixit02 Vaibhavdixit02 merged commit d4a014a into main Apr 30, 2024
5 checks passed
@Vaibhavdixit02 Vaibhavdixit02 deleted the at/use-reusable-workflows branch April 30, 2024 18:23
@Vaibhavdixit02
Copy link
Member

Even though it passed tests in the PR the CI on master seems to have broken can you take a look @thazhemadam?

@gdalle
Copy link
Collaborator

gdalle commented May 2, 2024

I re-ran the failed workflows and it worked, I think it was just a Codecov glitch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants