Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Julia 1.6 for Turing and others #52

Merged
merged 2 commits into from
May 2, 2024
Merged

Support Julia 1.6 for Turing and others #52

merged 2 commits into from
May 2, 2024

Conversation

gdalle
Copy link
Collaborator

@gdalle gdalle commented May 2, 2024

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Judging by the discussion with @devmotion in tpapp/LogDensityProblemsAD.jl#29 (comment), support for 1.6 is important in other parts of the ecosystem, even though SciML is willing to drop it sooner. The maintenance burden is very minimal in ADTypes.jl, so I'm adding it again.

Related discussions:

Copy link

codecov bot commented May 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (d4a014a) to head (9a7fa8d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #52   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines           64        64           
=========================================
  Hits            64        64           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdalle gdalle requested a review from Vaibhavdixit02 May 2, 2024 05:53
@gdalle gdalle merged commit 01b1259 into main May 2, 2024
5 checks passed
@gdalle gdalle deleted the gd/julia16_again branch May 2, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants