Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GTPSA extension #1107

Merged
merged 2 commits into from
Jan 3, 2025
Merged

Add GTPSA extension #1107

merged 2 commits into from
Jan 3, 2025

Conversation

mattsignorelli
Copy link
Contributor

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

This PR adds a DiffEqBase.value overload for the GTPSA.jl package so that GTPSA Taylor maps can be integrated.

@ChrisRackauckas
Copy link
Member

can you add a downstream integration test that covers this? https://github.com/SciML/DiffEqBase.jl/tree/master/test/downstream

@mattsignorelli
Copy link
Contributor Author

OK! I have added an integration test for (parametric) GTPSA maps including comparison of the Jacobian and Hessians with ForwardDiff

@ChrisRackauckas ChrisRackauckas merged commit a9f73bb into SciML:master Jan 3, 2025
26 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants