fix: kernel functions #853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`abs(t) > 0` will give all points except 0. This means K(t) will result in 0 for all points except 0. That is incorrect.
|
Is there a nice test for this? |
|
What kind of tests should I add? Unit tests for all the kernels or regression tests similar to https://github.com/SciML/DiffEqFlux.jl/blob/master/test/collocation_regression.jl? I see only |
That would be good. |
1. All tests in one file 2. Check collocation of data
into kernel functions
sathvikbhagavan
force-pushed
the
patch-1
branch
from
acdc06a
to
41d1031
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
abs(t) > 0will give all points except 0. This means K(t) will result in 0 for all points except 0. That is incorrect.