Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: explicitly specify token for codecov #23

Merged
merged 1 commit into from
Mar 27, 2024
Merged

Conversation

thazhemadam
Copy link
Member

Explicitly specify the codecov token to be used (i.e., CODECOV_TOKEN), given that the latest v4 release of the codecov action requires it to be able to generate coverage reports.

Additionally, fail CI if coverage reporting fails, since coverage is an important enough metric for us to ensure that it's tracked consistently.

Explicitly specify the codecov token to be used (i.e., `CODECOV_TOKEN`),
given that the latest v4 release of the codecov action requires it to be able to
generate coverage reports.

Additionally, fail CI if coverage reporting fails, since coverage is an important enough
metric for us to ensure that it's tracked consistently.


Signed-off-by: Anant Thazhemadam <47104651+thazhemadam@users.noreply.github.com>
Copy link

codecov bot commented Mar 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.25%. Comparing base (68a534d) to head (a4d1793).
Report is 40 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master      #23       +/-   ##
===========================================
+ Coverage   49.28%   66.25%   +16.96%     
===========================================
  Files           4        9        +5     
  Lines         211      243       +32     
===========================================
+ Hits          104      161       +57     
+ Misses        107       82       -25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nicholaskl97 nicholaskl97 merged commit fa6eb90 into master Mar 27, 2024
4 of 5 checks passed
@nicholaskl97 nicholaskl97 deleted the thazhemadam-patch-1 branch March 27, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants