Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated demos to use new Lux.PeriodicEmbedding #27

Merged
merged 4 commits into from
May 14, 2024
Merged

Conversation

nicholaskl97
Copy link
Collaborator

@nicholaskl97 nicholaskl97 commented May 14, 2024

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Instead of using WrappedFunction, there's now a Lux layer to embed $\theta$ as $(\sin \theta, \cos \theta)$, courtesy of LuxDL/Lux.jl#626.

Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.63%. Comparing base (96f2125) to head (1ee202f).

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #27   +/-   ##
=======================================
  Coverage   76.63%   76.63%           
=======================================
  Files          10       10           
  Lines         244      244           
=======================================
  Hits          187      187           
  Misses         57       57           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nicholaskl97 nicholaskl97 merged commit f93a351 into master May 14, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant