Added support for smooth loss functions to RoAAwareDecreaseCondition
#29
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Previously,
RoAAwareDecreaseCondition
had an inequality being used to detect if the in-RoA or out-of-RoA loss should be applied. This PR replaces that inequality with a function which can be a smooth approximation of the inequality.Additionally, this PR adds tests for fallback functions for
AbstractLyapunovMinimizationCondition
andAbstractLyapunovDecreaseCondition
methods to improve code coverage.