Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming decrease conditions #30

Merged
merged 14 commits into from
Sep 11, 2024
Merged

Conversation

nicholaskl97
Copy link
Collaborator

@nicholaskl97 nicholaskl97 commented Sep 11, 2024

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Decrease conditions AsymptoticDecrease and ExponentialDecrease are being renamed AsymptoticStability and ExponentialStability. Additionally, their strict option is being removed for increased simplicity and StabilityISL is being added to cover the strict = false case from AsymptoticDecrease, which should be a clearer/more accurate name.

Furthermore, this PR fixes many documentation typos.

@nicholaskl97 nicholaskl97 changed the title Renaming decrease conditions, fixing many documentation typos Renaming decrease conditions Sep 11, 2024
@nicholaskl97 nicholaskl97 marked this pull request as ready for review September 11, 2024 19:39
@nicholaskl97 nicholaskl97 merged commit 6e24f18 into master Sep 11, 2024
3 of 4 checks passed
@nicholaskl97 nicholaskl97 deleted the decrease_condition_renames branch September 11, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant