Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: correctly lower quadrature training strategy in NNODE #836

Merged
merged 8 commits into from
Mar 22, 2024
Merged

refactor: correctly lower quadrature training strategy in NNODE #836

merged 8 commits into from
Mar 22, 2024

Conversation

sathvikbhagavan
Copy link
Member

@sathvikbhagavan sathvikbhagavan commented Mar 21, 2024 •
edited
Loading

Along with correctly lowering quadrature training strategy in NNODE, things done:

  1. batch keyword is incorrectly described in NNODE docstring
  2. default tolerances were switched out for abstol and reltol in quadrature training.
  3. Lux.transform is deprecated for FromFluxAdaptor

@ChrisRackauckas
Copy link
Member

It seems the tolerances just need to be changed?

@ChrisRackauckas ChrisRackauckas merged commit 0cb2e06 into SciML:master Mar 22, 2024
24 of 29 checks passed
@sathvikbhagavan sathvikbhagavan mentioned this pull request Mar 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisRackauckas ChrisRackauckas ChrisRackauckas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sathvikbhagavan @ChrisRackauckas