ci: standardise workflows using SciML's reusable workflows #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thazhemadam
force-pushed
the
at/use-reusable-workflows
branch
from
d14b928
to
4e3d944
Compare
All the deprecations in the package itself have been appropriately
fixed up.
However, currently, tests fail when `depwarn` is set to error because of
a transitive dependency's depwarn, which is not directly influenced by
the package's primitives itself.
```julia
WARNING: using deprecated binding Colors.RGB1 in PlotUtils.
, use XRGB instead.
PlotUtils.RGB1 is deprecated, use ColorTypes.XRGB{T} where T<:Union{AbstractFloat, FixedPointNumbers.FixedPoint{T, f} where f where T<:Integer} instead.
WARNING: using deprecated binding Colors.RGB4 in PlotUtils.
, use RGBX instead.
PlotUtils.RGB4 is deprecated, use ColorTypes.RGBX{T} where T<:Union{AbstractFloat, FixedPointNumbers.FixedPoint{T, f} where f where T<:Integer} instead.
```
Thus, set `depwarn` to just `yes` while runnning the julia tests, so
that CI can pass.
|
@thazhemadam No coverage has been uploaded after merging this PR. This isn't very pleasant since I would like to keep track of coverage information with both Coveralls and Codecov. |
|
We can discuss this at the top level in https://github.com/SciML/.github. Codecov on forks is broken though at the Codecov service level, so we may just need to globally move everything to coveralls. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the workflows in this repository to use SciML's reusable workflows.
This is part of a larger effort to standardise the SciML's CI workflows for more generic and common requirements, to keep the workflows uniform and easier to maintain.