Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support 0-arg functions #29

Merged
merged 3 commits into from
Aug 10, 2023
Merged

support 0-arg functions #29

merged 3 commits into from
Aug 10, 2023

Conversation

shashi
Copy link
Contributor

@shashi shashi commented Mar 3, 2021

splitdef will return a dict without the :args key if you pass in an empty function expression.

Fixes #53.

@ChrisRackauckas
Copy link
Member

Looks like a real test failure.

@sleweke-bayer
Copy link

sleweke-bayer commented Aug 10, 2023

Any updates on this? Can it be merged?

@ChrisRackauckas
Copy link
Member

I mean, it's a stale PR that doesn't pass tests. If anyone updates it to something that works we can merge it, but of course this can't be merged as-is.

@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Merging #29 (1b3af21) into master (3991571) will increase coverage by 0.02%.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #29      +/-   ##
==========================================
+ Coverage   96.52%   96.55%   +0.02%     
==========================================
  Files           1        1              
  Lines         115      116       +1     
==========================================
+ Hits          111      112       +1     
  Misses          4        4              
Files Changed Coverage Δ
src/RuntimeGeneratedFunctions.jl 96.55% <100.00%> (+0.02%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ChrisRackauckas ChrisRackauckas merged commit 28def96 into SciML:master Aug 10, 2023
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failure when defining a function with no args
4 participants