Make Gridliner deprecation warning show up #2387
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Follow up to #2330. The deprecation warning is currently not showing for normal use. I thought I had checked but perhaps I only looked in test output. I've now set the stacklevel to 3 for when
Gridliner
is created viaax.gridlines
, and to 2 for the possible (but unlikely?) cases where aGridliner
is created directly.I have checked locally that this now gives the desired results
Implications