Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate DateTime provider #22

Closed
Scogun opened this issue Jan 8, 2024 · 4 comments · Fixed by #26
Closed

Separate DateTime provider #22

Scogun opened this issue Jan 8, 2024 · 4 comments · Fixed by #26
Assignees
Labels
enhancement New feature or request

Comments

@Scogun
Copy link
Owner

Scogun commented Jan 8, 2024

General Information

Right now we use kotlinx-datetime as multiplatform solution.
However, sometimes it make sense to use other DateTime provider.

Possible Solution

We have to extract any work with LocalDateTime into injected abstract DateTimeProvider.
We also must extract the functionality without the kotlinx-datetime library into kcron-common-core library.
As default implementation we must keep kcron-common package which will use kotlinx-datetime as DateTime implementation.

@Scogun Scogun added the enhancement New feature or request label Jan 8, 2024
@Scogun Scogun self-assigned this Jan 8, 2024
@Scogun
Copy link
Owner Author

Scogun commented Jan 12, 2024

After some investigation, I found that there is no better KMP date-time library than kotlinx-datetime.
So, maybe add the possibility to use different date-time provider is good but it should not reduce the current platforms amount.

@romualdbassinot
Copy link

romualdbassinot commented Jan 20, 2024

Hi, in my case I would use your dependency in a JVM context, but without an other dependency like kotlinx-datetime as DateTime implementation. The JDK give already the java.time and I prefer to avoid to multiply dependency to do the same things.

@Scogun Scogun linked a pull request Jan 22, 2024 that will close this issue
@Scogun
Copy link
Owner Author

Scogun commented Jan 22, 2024

Hello @romualdbassinot!

Could you look into my PR?

@romualdbassinot
Copy link

Thanks I will look this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants