Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/date time provider #26

Merged
merged 6 commits into from
Jan 25, 2024
Merged

Feature/date time provider #26

merged 6 commits into from
Jan 25, 2024

Conversation

Scogun
Copy link
Owner

@Scogun Scogun commented Jan 22, 2024

The solution was split on next modules:

  1. KCron-Abstraction - interfaces for DateTime providers
  2. KCron-Core - core functionality for Cron calculation
  3. KCron-Kotlinx-DateTime - Kotlinx DateTime implementation of DateTime Provider
  4. KCron-Common - Cron realization uses Kotlinx DateTime Provider

@Scogun Scogun linked an issue Jan 22, 2024 that may be closed by this pull request
Separate DateTime provider #22
Closed
@Scogun Scogun force-pushed the feature/date-time-provider branch 4 times, most recently from bae037f to 82a68e4 Compare January 22, 2024 14:55
@Scogun Scogun force-pushed the feature/date-time-provider branch 2 times, most recently from e872b73 to e6dc3cd Compare January 22, 2024 15:04
romualdbassinot
romualdbassinot reviewed Jan 23, 2024
View reviewed changes
Copy link

@romualdbassinot romualdbassinot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the adaptation, I have finished to give my suggestions.

kcron-core/src/commonMain/kotlin/com/ucasoft/kcron/core/builders/Builder.kt Outdated Show resolved Hide resolved
kcron-core/src/commonMain/kotlin/com/ucasoft/kcron/core/builders/Builder.kt Show resolved Hide resolved
kcron-core/src/commonMain/kotlin/com/ucasoft/kcron/core/builders/Builder.kt Show resolved Hide resolved
kcron-core/src/commonMain/kotlin/com/ucasoft/kcron/core/parsers/Parser.kt Outdated Show resolved Hide resolved
kcron-core/src/commonTest/kotlin/com/ucasoft/kcron/core/parsers/MonthPartTests.kt Outdated Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 24, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
No data about Coverage
2.4% Duplication on New Code

See analysis details on SonarCloud

@Scogun Scogun self-assigned this Jan 25, 2024
@Scogun Scogun merged commit 067a3d8 into main Jan 25, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romualdbassinot romualdbassinot romualdbassinot approved these changes

Assignees

@Scogun Scogun

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Separate DateTime provider
2 participants
@Scogun @romualdbassinot